Skip to content

Vidur/incident update#272

Merged
naasanov merged 53 commits intomainfrom
vidur/incident-update
Apr 7, 2026
Merged

Vidur/incident update#272
naasanov merged 53 commits intomainfrom
vidur/incident-update

Conversation

@VidurShah
Copy link
Copy Markdown
Collaborator

Align incident backend with updated TDD/API contract.

Changes:

  • Updated incident severity values to remote_warning, in_person_warning, citation.
  • Added optional reference_id across incident DTOs, entity, service, and list filters/sorts.
  • Updated incident update flow to accept location_place_id and resolve/create location.
  • Refactored incident model layering to keep API request fields separate from internal data fields.
  • Updated incident + query-utils tests to cover new severities, reference_id, and update-location behavior.

Closes #235

mfandohan05 and others added 30 commits February 8, 2026 23:11
@VidurShah VidurShah requested a review from naasanov March 30, 2026 15:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Test Results Summary

559 tests  +8   559 ✅ +8   38s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0770c7e. ± Comparison against base commit 96cac6f.

♻️ This comment has been updated with latest results.

@naasanov naasanov closed this Apr 4, 2026
@naasanov naasanov reopened this Apr 4, 2026
Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small thing. Excel export for incidents was merged in main with the old structure. You'll have to update the excel export in the service with the new values and ref id. Just a couple lines change.

@naasanov naasanov force-pushed the vidur/incident-update branch from d2c5143 to 3383de3 Compare April 7, 2026 20:39
Base automatically changed from aileen/frontend-incidents-table to main April 7, 2026 21:48
Copy link
Copy Markdown
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naasanov naasanov merged commit 7754498 into main Apr 7, 2026
3 checks passed
@naasanov naasanov deleted the vidur/incident-update branch April 7, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend Incident Update + Integration

4 participants