Skip to content

Senator Roster Page UI#137

Merged
calebyhan merged 2 commits intomainfrom
sonal-branch
Apr 20, 2026
Merged

Senator Roster Page UI#137
calebyhan merged 2 commits intomainfrom
sonal-branch

Conversation

@msonal1
Copy link
Copy Markdown
Contributor

@msonal1 msonal1 commented Apr 20, 2026

Motivation:
Students need visibility into who represents them; the senator roster is a core transparency feature. This PR implements the roster page with search, sort, and navigation, and establishes the pattern for future data tables in the app.

Changes:

  • Added /senators/roster/page.tsx with a Shadcn Table displaying headshot, full name, district, committee assignments, and email
  • Added client-side search input that filters senators by name
  • Made name and district columns sortable via header clicks
  • Clicking a senator's row or name navigates to /senators/[id]
  • Wired the table to getSenators() from the API client, with mock data fallback
  • Added headshot fallback that renders initials when headshot_url is null
  • Formatted committee assignments as "Finance (Member), Rules (Vice Chair)" from the nested CommitteeAssignmentDTO list
  • Made the table horizontally scrollable on mobile

Closes #14

@calebyhan calebyhan changed the title Senator Roster Page UI #14 Senator Roster Page UI Apr 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Test Results

555 tests  ±0   555 ✅ ±0   5s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f4cbb6a. ± Comparison against base commit 2f010ba.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@calebyhan calebyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had to do some funny force push smth, hope this works

@calebyhan calebyhan merged commit 2b25241 into main Apr 20, 2026
3 checks passed
@calebyhan calebyhan deleted the sonal-branch branch April 20, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Senator Roster Page UI

2 participants