Merged
Conversation
- Add GET /api/news (paginated, published only, most-recent-first)
- Add GET /api/news/{id} (404 for drafts or nonexistent)
- Add GET /api/senators (filterable: search, district_id, committee, session)
- Add GET /api/senators/{id} (with committee assignments, any session)
- Add app/utils/pagination.py reusable paginate() helper
- Add app/schemas/pagination.py PaginatedResponse[T] generic envelope
- Register both routers in app/main.py
- Add try/except guard for PR #37 NewsDTO/SenatorDTO schemas
- Add tests/routes/ integration test suite (43 tests, SQLite in-memory)
- 13 tests for news endpoints
- 26 tests for senator endpoints
- conftest seeds districts, admin, news, committees, senators, memberships
126 tests pass, 0 failures
calebyhan
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully will work well with the Pydantic Schemas — Public Output DTOs that Gabriel worked on. If not, I can come back and look at it.
Closes #6