Skip to content

chore: add repository directory for all packages.json#1586

Merged
kof merged 1 commit intocssinjs:masterfrom
unrevised6419:package-json-repository-directory
Apr 16, 2022
Merged

chore: add repository directory for all packages.json#1586
kof merged 1 commit intocssinjs:masterfrom
unrevised6419:package-json-repository-directory

Conversation

@unrevised6419
Copy link
Copy Markdown
Contributor

@unrevised6419 unrevised6419 commented Nov 22, 2021

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:

"repository": {
  "type" : "git",
  "url" : "https://github.com/facebook/react.git",
  "directory": "packages/react-dom"
}

https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79

> If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:
> ```json
> "repository": {
>   "type" : "git",
>   "url" : "https://github.com/facebook/react.git",
>   "directory": "packages/react-dom"
> }
> ```
> — https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79
@unrevised6419 unrevised6419 requested a review from kof as a code owner November 22, 2021 16:45
@unrevised6419 unrevised6419 deleted the package-json-repository-directory branch December 9, 2021 12:29
@kof
Copy link
Copy Markdown
Member

kof commented Dec 9, 2021

hi, was this wrong or why did you close?

@unrevised6419 unrevised6419 restored the package-json-repository-directory branch December 9, 2021 23:29
@unrevised6419 unrevised6419 reopened this Dec 9, 2021
@unrevised6419
Copy link
Copy Markdown
Contributor Author

unrevised6419 commented Dec 9, 2021

Hi. Just cleaned up old Open PR's, that have no activity. Reopened 🚀

@kof kof merged commit f4d1d5e into cssinjs:master Apr 16, 2022
@unrevised6419 unrevised6419 deleted the package-json-repository-directory branch April 18, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants