Conversation
- move documentation to the package - update docs, since plugins don't apply by default - introduce option process: true to the plugin to enable plugins if user wants that
kof
requested review from
HenriBeck and
TrySound
and removed request for
HenriBeck
Member
|
Could we maybe also use the |
Member
|
Is this branch supposed to have all of the changes of the dynamic values PR or was it an accident? |
Member
Author
totally, added a separate issue for it #885
Just wanted to avoid conflicts, since the other PR is going to be merged soon and its quite massive |
Member
|
👍 will review the dynamic values as soon as possible |
HenriBeck
approved these changes
Oct 13, 2018
HenriBeck
pushed a commit
that referenced
this pull request
Oct 16, 2018
* master: Support plugins processing for observables by default (#892) Typed CSSOM values support (#887) Dynamic values full syntax (#878) [jss-plugin-cache] Use WeakMap for cache plugin (#890) # Conflicts: # packages/jss-plugin-syntax-rule-value-function/.size-snapshot.json # packages/jss-preset-default/.size-snapshot.json # packages/jss/.size-snapshot.json # packages/react-jss/.size-snapshot.json
HenriBeck
pushed a commit
that referenced
this pull request
Oct 22, 2018
* origin/add-ts-typings: Scoped keyframes (#888) Update readme.md (#897) Use CSSTOM in default unit plugin (#893) Added .nvmrc (#896) [WIP] DONT MERGE Fix ci (#895) Update ci (#894) Support plugins processing for observables by default (#892) Typed CSSOM values support (#887) Dynamic values full syntax (#878) [jss-plugin-cache] Use WeakMap for cache plugin (#890)
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* added fallbacks test to fn rules * only call onChangeValue if plugins: true * enable removing props from fn rules * shorter syntax with coercion * wip full syntax support * restore browsers.json * changelog * move hook call to the core * isProcessed flag explanation * added tests to fn rules * remove media rule as a function test case * added a test for cssinjs#796, as part of cssinjs#682 * tests for compose plugin * observables - move documentation to the package - update docs, since plugins don't apply by default - introduce option process: true to the plugin to enable plugins if user wants that * move fn values docs * wording * support typed cssom * Update docs/json-api.md * Update changelog.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#882
Branch is based on #878 so it needs to be merged first for a sane diff.