analyzer_bin_envvar used to get analyzer binary in runtime#5
Closed
sibeream wants to merge 2 commits intocsutils:mainfrom
sibeream:analyzer_alternative
Closed
analyzer_bin_envvar used to get analyzer binary in runtime#5sibeream wants to merge 2 commits intocsutils:mainfrom sibeream:analyzer_alternative
sibeream wants to merge 2 commits intocsutils:mainfrom
sibeream:analyzer_alternative
Conversation
kdudka
requested changes
Sep 22, 2021
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Thanks! It works for me. I suggest a few minor changes inline.
kdudka
reviewed
Sep 22, 2021
1. analyzer_bin_envvar renamed to analyzer_bin_envvar_name 2. CSGCCA_ANALYZER_BIN documented 3. comments in code are updated
Member
|
Thanks for the quick turnaround! Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules can define analyzer_bin_envvar field as non-NULL. If it's done, an environment variable with the same name as the value of the field will be used to determine the path to the analyzer binary.