Skip to content

csparser: abstract out insignificant information #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdudka merged 1 commit into from
Feb 25, 2022
Merged

csparser: abstract out insignificant information #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/csfilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ MsgFilter::MsgFilter():
// unify (per build random) names of temporary variables
d->addMsgFilter("COMPILER_WARNING", "_tmp[0-9]+_", "_tmp_");

// abstract out <Uf260> vs. <U4260> in:
// "use of uninitialized value 'table_key.<Uf260>.str'"
d->addMsgFilter("GCC_ANALYZER",
"^(use of uninitialized value '[^'<]+\\.<)[^>]+(>.[^']+)'",
"\\1XXX\\2");

// auxiliary info provided by valgrind directly in the key event message
d->addMsgFilter("VALGRIND_WARNING",
" lost in loss record [0-9,]+ of [0-9,]+$", "");
Expand Down
1 change: 1 addition & 0 deletions tests/csdiff/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@ test_csdiff(diff-misc 09-shellcheck-raw)
test_csdiff(diff-misc 10-pylint-copr)
test_csdiff(diff-misc 11-pylint-copr-json)
test_csdiff(diff-misc 12-shellcheck-sc222x)
test_csdiff(diff-misc 13-gcca-filt)

add_subdirectory(filter-file)
Empty file added tests/csdiff/diff-misc/13-gcca-filt-add-z.err
View file
Open in desktop
Empty file.
Empty file added tests/csdiff/diff-misc/13-gcca-filt-add.err
View file
Open in desktop
Empty file.
Empty file added tests/csdiff/diff-misc/13-gcca-filt-fix-z.err
View file
Open in desktop
Empty file.
Empty file added tests/csdiff/diff-misc/13-gcca-filt-fix.err
View file
Open in desktop
Empty file.
10 changes: 10 additions & 0 deletions tests/csdiff/diff-misc/13-gcca-filt-new.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Error: GCC_ANALYZER_WARNING (CWE-457):
sssd-2.6.3/src/lib/sifp/sss_sifp_parser.c: scope_hint: In function 'sss_sifp_parse_dict'
sssd-2.6.3/src/lib/sifp/sss_sifp_parser.c:233:18: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value 'table_key.<U4260>.str'
sssd-2.6.3/src/lib/sifp/sss_sifp_parser.c:461:5: note: in expansion of macro 'check_dbus_arg'
sssd-2.6.3/src/lib/sifp/sss_sifp_parser.c:147:5: note: in expansion of macro 'check_dbus_arg'
# 231|
# 232| done:
# 233|-> if (table_key.str != NULL) {
# 234| _free(ctx, table_key.str);
# 235| }
10 changes: 10 additions & 0 deletions tests/csdiff/diff-misc/13-gcca-filt-old.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Error: GCC_ANALYZER_WARNING (CWE-457):
sssd-test_build_base_srpm_225/src/lib/sifp/sss_sifp_parser.c: scope_hint: In function 'sss_sifp_parse_dict'
sssd-test_build_base_srpm_225/src/lib/sifp/sss_sifp_parser.c:233:18: warning[-Wanalyzer-use-of-uninitialized-value]: use of uninitialized value 'table_key.<Uf260>.str'
sssd-test_build_base_srpm_225/src/lib/sifp/sss_sifp_parser.c:461:5: note: in expansion of macro 'check_dbus_arg'
sssd-test_build_base_srpm_225/src/lib/sifp/sss_sifp_parser.c:147:5: note: in expansion of macro 'check_dbus_arg'
# 231|
# 232| done:
# 233|-> if (table_key.str != NULL) {
# 234| _free(ctx, table_key.str);
# 235| }