Skip to content

Conversation

@guidojw
Copy link
Member

@guidojw guidojw commented Nov 21, 2020

This PR adds a Docker Compose configuration file that can be used during the development phase. With this file you can run the project without installing the required dependencies; Docker will do this for you.
This for example allows you to run the API on your Windows machine.

Change the COMPOSE_PROJECT_NAME in .env from amber_<env> to amber_development so that the Docker configuration for running the UI in development can connect to the network created by this configuration. As stated in this PR on the UI.

@guidojw guidojw marked this pull request as ready for review November 21, 2020 14:02
@guidojw
Copy link
Member Author

guidojw commented Nov 21, 2020

To avoid having to write -f docker-compose.development.yml in all the commands maybe I could change the current docker-compose.yml to docker-compose.production.yml and then the docker-compose.development.yml to docker-compose.yml?
The current docker-compose.yml isn't really used apart from on the server so I don't think it would be a big problem to change it like this.

@guidojw guidojw requested a review from Matthijsy April 19, 2021 19:18
@cpbscholten cpbscholten self-requested a review May 17, 2021 19:39
@guidojw guidojw enabled auto-merge (squash) May 17, 2021 20:06
@guidojw guidojw merged commit bd740a7 into staging May 17, 2021
@guidojw guidojw deleted the feature/docker-dev branch May 17, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants