Skip to content

Conversation

@guidojw
Copy link
Member

@guidojw guidojw commented Dec 9, 2021

New errors on production are being coupled to the wrong release on Sentry, most likely because of release name in config/environment.js, so this PR fixes that. We use commit SHAs for release names and those are always unique so the amber-ui@ prefix is not necessary.

Release they should be coupled to: https://sentry.io/organizations/csvalpha/releases/8a161b19d172cf23b4fb93861af65c9e2eecfea1/?project=186017

Edit: added two other fixes:

  • When deploying to master with a merge, the commit SHA of the head commit before the merge was used in the release action.
  • Removed environment from the release action call in Publish Image, to not have Sentry create a deployment (reference).

@guidojw guidojw enabled auto-merge (squash) December 9, 2021 15:51
@DrumsnChocolate
Copy link
Contributor

I assume you mean we can leave out the project name prefix in the release settings, because we only use sentry for this project?

@DrumsnChocolate
Copy link
Contributor

I don't understand much of the contents of the yaml files, but the changes are fairly small and seem reasonable to me. Have you been able to verify that this does indeed work, or are you hoping this fixes the issue once pushed to production?

@guidojw
Copy link
Member Author

guidojw commented Jan 19, 2022

I don't understand much of the contents of the yaml files, but the changes are fairly small and seem reasonable to me. Have you been able to verify that this does indeed work, or are you hoping this fixes the issue once pushed to production?

Yes, similar action configurations work on my own projects.

@guidojw guidojw merged commit f251577 into staging Jan 19, 2022
@guidojw guidojw deleted the fix/sentry-release branch January 19, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants