Skip to content

Conversation

@lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Jan 29, 2026

Checklist

  • Merged database migrations into 1 database migration.
  • Tested database migrations from origin/staging (git checkout staging ; git pull ; bundle exec rails db:reset ; git checkout BRANCH ; bundle exec rails db:migrate).

Summary

Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.

Other information

If there is some other relevant and important information for this pull request, mention it here. For example, related pull requests or newly introduced conventions, packages or other dependencies.

Summary by CodeRabbit

  • Chores
    • Added support for a new demo environment configuration, including deployment settings, database configuration, and environment-specific settings to enable testing and demonstration purposes.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 29, 2026 19:57
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request introduces a new "demo" environment configuration across the Rails application infrastructure. The changes add demo environment entries to CI/CD workflows, deployment targets, Rails configuration files, and supporting configuration systems like RuboCop, cable, and database settings.

Changes

Cohort / File(s) Summary
CI/CD & Deployment Configuration
.github/workflows/continuous-delivery.yml, config/deploy_targets.yml, config/environments/demo.rb
Adds "demo" as a deployable target with endpoint demostreep.csvalpha.nl, deploy path /opt/docker/sofia/demo, stage "demo", and branch restriction to "master". The Rails environment file inherits production configuration.
Application Configuration
.rubocop.yml, config/cable.yml, config/database.yml
Extends configuration blocks to include "demo" environment: RuboCop recognizes demo as valid environment, cable configuration mirrors production via YAML merge alias, and database configuration inherits from production template.
Encrypted Credentials
config/credentials.yml.enc
Updates encrypted credentials content; internal structure and purpose remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A demo stage hops into view,
Configuration files dressed in something new,
Production's twin in demostreep's land,
Where testing flows run swift and grand! 🚀

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Rails demo environment/stage that mirrors production settings and wires it into deployment configuration and tooling.

Changes:

  • Add config/environments/demo.rb inheriting production configuration.
  • Register demo in deploy targets plus database and Action Cable environment configs.
  • Allow selecting demo in the CD workflow and whitelist it for RuboCop’s unknown env check.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
config/environments/demo.rb Introduces demo Rails environment inheriting production defaults
config/deploy_targets.yml Adds a demo deployment target (path/hostname/url/branch restriction)
config/database.yml Adds demo DB config inheriting production
config/cable.yml Adds demo Action Cable config inheriting production
.rubocop.yml Adds demo to Rails/UnknownEnv allowlist
.github/workflows/continuous-delivery.yml Adds demo as a selectable deployment target

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +6
Rails.application.configure do
# Only override production when applicable
# Keep in mind that demo should reflect production as close as possible
end
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description still contains the template checklist/summary (e.g., migration checklist) and doesn’t describe the actual change (adding a demo environment + deploy target). Please update the PR description so reviewers/operators know what to expect and how to use the new demo stage.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (300812f) to head (6fa38a5).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1219   +/-   ##
========================================
  Coverage    77.11%   77.11%           
========================================
  Files           54       54           
  Lines         1372     1372           
========================================
  Hits          1058     1058           
  Misses         314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lodewiges lodewiges merged commit 5ad8626 into staging Jan 29, 2026
1 check passed
@lodewiges lodewiges deleted the feature/add-demo-env branch January 29, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants