-
Notifications
You must be signed in to change notification settings - Fork 3
Create demo environment configuration #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request introduces a new "demo" environment configuration across the Rails application infrastructure. The changes add demo environment entries to CI/CD workflows, deployment targets, Rails configuration files, and supporting configuration systems like RuboCop, cable, and database settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a new Rails demo environment/stage that mirrors production settings and wires it into deployment configuration and tooling.
Changes:
- Add
config/environments/demo.rbinheriting production configuration. - Register
demoin deploy targets plus database and Action Cable environment configs. - Allow selecting
demoin the CD workflow and whitelist it for RuboCop’s unknown env check.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| config/environments/demo.rb | Introduces demo Rails environment inheriting production defaults |
| config/deploy_targets.yml | Adds a demo deployment target (path/hostname/url/branch restriction) |
| config/database.yml | Adds demo DB config inheriting production |
| config/cable.yml | Adds demo Action Cable config inheriting production |
| .rubocop.yml | Adds demo to Rails/UnknownEnv allowlist |
| .github/workflows/continuous-delivery.yml | Adds demo as a selectable deployment target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Rails.application.configure do | ||
| # Only override production when applicable | ||
| # Keep in mind that demo should reflect production as close as possible | ||
| end |
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description still contains the template checklist/summary (e.g., migration checklist) and doesn’t describe the actual change (adding a demo environment + deploy target). Please update the PR description so reviewers/operators know what to expect and how to use the new demo stage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1219 +/- ##
========================================
Coverage 77.11% 77.11%
========================================
Files 54 54
Lines 1372 1372
========================================
Hits 1058 1058
Misses 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checklist
origin/staging(git checkout staging ; git pull ; bundle exec rails db:reset ; git checkout BRANCH ; bundle exec rails db:migrate).Summary
Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.
Other information
If there is some other relevant and important information for this pull request, mention it here. For example, related pull requests or newly introduced conventions, packages or other dependencies.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.