Retire referencePending: gocsvj enforces §1 rules#4
Open
peo-machine wants to merge 1 commit into
Open
Conversation
gocsvj#12 (reader: enforce strict §1 structural rules) shipped the six behaviors the conformance runner was skipping for the reference implementation: single-`\n` accept, missing-trailing-newline reject, ragged-row short/long reject, duplicate-header-names reject, duplicate-empty-header reject. Bumps the gocsvj pin to master (post-#12), drops the `referencePending` map and the two skip clauses in `conformance_test.go`, and removes the corresponding §"Reference impl pending list" subsection from README.md. All 7 input vectors and 18 must-reject vectors now pass against gocsvj@master without skips. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gocsvj#12 (merged) shipped strict §1 structural-rule enforcement in the reference Go implementation. The six skip-list entries in
conformance_test.go'sreferencePendingmap can now retire:05-empty-header-line(accept)\nis the minimum valid file05-missing-trailing-newline(reject)06-ragged-row-short(reject)07-ragged-row-long(reject)08-duplicate-header-names(reject)09-duplicate-empty-header(reject)Changes
gocsvjpin ingo.modto master (post-#12 —v0.0.0-20260526150927-654752620b64).referencePendingmap and its two skip clauses fromconformance_test.go.README.md— no entries left to document.After this PR, the Go runner exercises every vector against gocsvj with no skips, matching what other-language implementers are already expected to do.
Verified locally
Test plan
go test ./...).🤖 Generated with Claude Code