Wire csvj-org/conformance suite into CI#3
Merged
Conversation
Adds a `conformance` GHA job that checks out `csvj-org/conformance@master` alongside this repo and runs an opt-in `conformance` PHPUnit testsuite against every vector — 7 accept + 18 must-reject, no skips. The default `vendor/bin/phpunit` run is unaffected: `defaultTestSuite="unit"` keeps it scoped to the existing unit tests, and the conformance suite is gated behind `--testsuite=conformance` and the `CSVJ_CONFORMANCE_DIR` env var. Closes PLAN.md §7a's "Wire conformance suite into CI" task. Same shape as gocsvj's conformance CI job (gocsvj#11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
conformanceGHA job that runs the language-agnosticcsvj-org/conformance suite
against this checkout on every push and PR — 7 accept + 18 must-reject
vectors, no skips. Mirrors the pattern already in
gocsvj(gocsvj#11).
tests/Conformance/ConformanceTest.phpwalks the vector treeusing data providers. Two test methods (accept / must-reject) each
iterate the matching directory; vector tree root comes from the
CSVJ_CONFORMANCE_DIRenv var set by CI.phpunit.xml.distnow declares two named testsuites —unit(existing 45 cases, excludes
tests/Conformance/) andconformance(the new driver).defaultTestSuite="unit"keepsthe existing
vendor/bin/phpunitinvocation unchanged, so thetestjob and localphpunitruns remain identical.conformanceCI job checks outcsvj-org/conformance@masterinto a sibling directory, installscomposer deps, and runs
vendor/bin/phpunit --testsuite=conformancewith the env var pointing at it.Closes PLAN.md §7a's "Wire conformance suite into CI" task.
Test plan
vendor/bin/phpunitlocally: 45 unit tests pass (default suiteunchanged).
CSVJ_CONFORMANCE_DIR=../conformance vendor/bin/phpunit --testsuite=conformancelocally: 25 conformance tests pass(7 accept + 18 must-reject, no skips).
testmatrix (PHP 8.2 / 8.3 / 8.4) — green.conformancejob — green.