Add English locale and i18n support for popup UI#1
Conversation
The popup UI was hardcoded in Spanish (popup.html, popup.js, and the manifest description), with no way to view it in English. - Add chrome.i18n support via _locales/en and _locales/es - Replace hardcoded strings in popup.html with data-i18n attributes - Replace hardcoded strings in popup.js with chrome.i18n.getMessage() calls - Add default_locale to manifest.json and switch name/description to __MSG_*__ placeholders - Bump version to 1.3.0 and update changelog Popup language now follows the browser's UI language, falling back to English if the locale isn't available. No functional changes.
Popup is now internationalized via chrome.i18n (_locales/en + es, default_locale=en). The UI follows the browser language: English by default, Spanish for es locales. manifest name/description use __MSG_*__; build:dist bundles _locales/. Re-implements @adc103's i18n proposal (PR #1) on the current popup — the original PR was based on the pre-1.5 popup and conflicted after the 1.5-1.7 rewrite (pause/resume, cookies, single-source presets). Credit to @adc103 for the approach (chrome.i18n + _locales + data-i18n). Bump 1.7.0 -> 1.8.0. Validated: 78 unit + 5 e2e green. Co-Authored-By: adc103 <adc103@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for this, @adc103 — really nice work, and good timing. 🙌 Heads-up on what happened: right after you opened this, a large refactor landed (v1.5–1.7) that rewrote the popup substantially — pause/resume, a "Download cookies" action, single-source presets from But the idea is great and exactly what the project needed, so I re-implemented your approach (
Closing this since the change is now in |
2 participants
Adds English support to the popup UI via chrome.i18n, alongside the existing Spanish. Popup language now follows the browser's UI locale (standard Chrome extension i18n behavior) rather than a manual switcher — happy to add an in-popup toggle if preferred. Bumped to 1.3.0 since this adds a feature rather than fixing a bug.