Fixes inspired by KYOCERA ECOSYS M2540dn#222
Closed
kpnr wants to merge 7 commits intoctalkington:masterfrom
kpnr:master
Closed
Fixes inspired by KYOCERA ECOSYS M2540dn#222kpnr wants to merge 7 commits intoctalkington:masterfrom kpnr:master
kpnr wants to merge 7 commits intoctalkington:masterfrom
kpnr:master
Conversation
- Added DATE parsing into Python datetime object - Added "unsupported-attributes" parsing
- status code in "successful" & "informational" range (0x0...0x1FF) not raising - fixed message merging (IPP._message)
"unsupported-attributes" and "informational status code" blobs
Test case for DATE, informational status-code
message merge & non-zero status-code tests
This was referenced Oct 3, 2022
ctalkington
added a commit
that referenced
this pull request
Oct 5, 2022
Owner
|
thanks for these updates. sorry it took some time to get back to this project. I had to manually re-implement them due to other big changes but I added you to the attribution in v0.12.0 release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day, Chris!
After some requests to IPP interface in KYOCERA ECOSYS M2540dn found some minor bugs/incompleteness.
Fixes:
Improvements:
All changes are covered with tests.
Awaiting your review & remarks.
Thank you, hkm...