Adding printer-more-info support#333
Merged
ctalkington merged 1 commit intoctalkington:masterfrom Oct 2, 2022
Merged
Conversation
23 tasks
ctalkington
approved these changes
Oct 2, 2022
Owner
|
I bet one of the test fixtures contains more info since have hp and epson ones. I can add such though before I make a release |
Contributor
Author
|
Will this trigger a new release then? I'll try to update the ha pr Monday/Tuesday. This will be much cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on home assistant which is using your library and opened a pull request to allow users to browse to the printer more-info url if provided: home-assistant/core#79313
As such we would need to implement this change into your library for the code changes I'm proposing to work.
Here is info on the more info section:
https://www.rfc-editor.org/rfc/rfc8011#section-5.4.7