Skip to content

Adding printer-more-info support#333

Merged
ctalkington merged 1 commit intoctalkington:masterfrom
jeeftor:master
Oct 2, 2022
Merged

Adding printer-more-info support#333
ctalkington merged 1 commit intoctalkington:masterfrom
jeeftor:master

Conversation

@jeeftor
Copy link
Copy Markdown
Contributor

@jeeftor jeeftor commented Sep 29, 2022

I've been working on home assistant which is using your library and opened a pull request to allow users to browse to the printer more-info url if provided: home-assistant/core#79313

As such we would need to implement this change into your library for the code changes I'm proposing to work.

Here is info on the more info section:
https://www.rfc-editor.org/rfc/rfc8011#section-5.4.7

[5.4.7](https://www.rfc-editor.org/rfc/rfc8011#section-5.4.7).  printer-more-info (uri)

   This RECOMMENDED Printer attribute contains a URI used to obtain more
   information about this specific Printer.  For example, this could be
   an HTTP URI referencing an HTML page accessible to a web browser.
   The information obtained from this URI is intended for End User
   consumption.  Features outside the scope of IPP can be accessed from
   this URI.  The information is intended to be specific to this Printer
   instance and site-specific services, e.g., Job pricing, services
   offered, and End User assistance.  The device manufacturer can
   initially populate this attribute.

@ctalkington
Copy link
Copy Markdown
Owner

I bet one of the test fixtures contains more info since have hp and epson ones. I can add such though before I make a release

@ctalkington ctalkington merged commit 7a4262a into ctalkington:master Oct 2, 2022
@ctalkington ctalkington added enhancement Enhancement of the code, not introducing new features. major This PR causes a major version bump in the version number. labels Oct 2, 2022
@jeeftor
Copy link
Copy Markdown
Contributor Author

jeeftor commented Oct 2, 2022

Will this trigger a new release then? I'll try to update the ha pr Monday/Tuesday. This will be much cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of the code, not introducing new features. major This PR causes a major version bump in the version number.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants