Allow for markers and URIs being single values#411
Merged
ctalkington merged 5 commits intoctalkington:masterfrom May 26, 2023
Merged
Allow for markers and URIs being single values#411ctalkington merged 5 commits intoctalkington:masterfrom
ctalkington merged 5 commits intoctalkington:masterfrom
Conversation
ctalkington
added
the
bugfix
ctalkington
changed the title
ctalkington
reviewed
May 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 92.83% 90.38% -2.45%
==========================================
Files 9 9
Lines 795 822 +27
Branches 108 117 +9
==========================================
+ Hits 738 743 +5
- Misses 23 39 +16
- Partials 34 40 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have investigated why I do not get ink/toner levels in Home Assistant for the IPP integration with my Canon MF230 laser printer (black only) when I stumbled upon this following open issue for the HA IPP integration.
After some digging I found the parsing to only cater for markers and URIs being list instances; I thus the changes in this pull request. Subsequently I see that there is already an open #410 , which this PR should fix.
Debug log from Home Assistant showing the IPP data: pyipp.log