Skip to content

Conversation

@enVolt
Copy link
Contributor

@enVolt enVolt commented Jul 4, 2016

An optional function, which will completely disable any error. (undefined is returned, instead of any error).

  • Test Case
  • version changed to 0.7.0
  • updated README.md
  • updated package.json

README.md Outdated
}
```

### env.disableError()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you call this disableErrors() so that the wording is consistent with disableFallbacks()?

@ctavan
Copy link
Owner

ctavan commented Jul 4, 2016

@enVolt thanks for this great contribution! I had two minor comments. Would you mind fixing them (and squashing them into this commit)? I'd then be happy to merge and publish.

@enVolt
Copy link
Contributor Author

enVolt commented Jul 5, 2016

@ctavan Thanks, this is my first ever contribution, so I was kind of nervous.

I kinda lost you squashing them into this commit, do you want me to recreate pull request, with single commit change?

@ctavan
Copy link
Owner

ctavan commented Jul 6, 2016

Just keep this pull-request but amend your existing commit, then force push... In practice:

# do your changes
git add *
git commit --amend
git push -f

@enVolt
Copy link
Contributor Author

enVolt commented Jul 6, 2016

Changes

  • reverted Change Log
  • package.json version
  • ___Errors

@enVolt
Copy link
Contributor Author

enVolt commented Jul 23, 2016

@ctavan ?

README.md Outdated

```javascript
getenv.disableErrors();
console.log(getenv("RANDOM");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a closing ) missing.

@ctavan
Copy link
Owner

ctavan commented Jul 25, 2016

@enVolt thanks for fixing! I discovered two more minor issues. Could you fix them? I'll merge afterwards.

@enVolt
Copy link
Contributor Author

enVolt commented Jul 30, 2016

Thanks for your input. I've updated the same commit. Please check.

@nguyeda
Copy link

nguyeda commented Oct 6, 2016

Hi guys, this is exactly the answer to a question I was about to ask. @ctavan do you already know if this is going to be merged? if so, is there an ETA on the 0.7 release?

Thanks for the great job 👍

@ctavan ctavan merged commit 4981843 into ctavan:master Oct 6, 2016
@ctavan
Copy link
Owner

ctavan commented Oct 6, 2016

Has been published as getenv@0.7.0

Thanks to @enVolt for the contribution.

@nguyeda
Copy link

nguyeda commented Oct 6, 2016

@ctavan that's awesome thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants