-
Notifications
You must be signed in to change notification settings - Fork 15
disableError() #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disableError() #11
Conversation
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### env.disableError() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you call this disableErrors() so that the wording is consistent with disableFallbacks()?
|
@enVolt thanks for this great contribution! I had two minor comments. Would you mind fixing them (and squashing them into this commit)? I'd then be happy to merge and publish. |
|
@ctavan Thanks, this is my first ever contribution, so I was kind of nervous. I kinda lost you |
|
Just keep this pull-request but amend your existing commit, then force push... In practice: |
|
Changes
|
|
@ctavan ? |
README.md
Outdated
|
|
||
| ```javascript | ||
| getenv.disableErrors(); | ||
| console.log(getenv("RANDOM"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a closing ) missing.
|
@enVolt thanks for fixing! I discovered two more minor issues. Could you fix them? I'll merge afterwards. |
|
Thanks for your input. I've updated the same commit. Please check. |
|
Hi guys, this is exactly the answer to a question I was about to ask. @ctavan do you already know if this is going to be merged? if so, is there an ETA on the 0.7 release? Thanks for the great job 👍 |
|
Has been published as getenv@0.7.0 Thanks to @enVolt for the contribution. |
|
@ctavan that's awesome thanks a lot 👍 |
An optional function, which will completely disable any error. (
undefinedis returned, instead of any error).README.mdpackage.json