Skip to content
This repository was archived by the owner on May 1, 2026. It is now read-only.

Add "version" command#51

Merged
cterence merged 5 commits intocterence:mainfrom
shayelkin:add-version-cmd
Sep 13, 2024
Merged

Add "version" command#51
cterence merged 5 commits intocterence:mainfrom
shayelkin:add-version-cmd

Conversation

@shayelkin
Copy link
Copy Markdown
Contributor

This adds a "version" command that does exactly what you'd expect: it prints to the standard output the (module) version of Tailscale, and the hash of the commit the build was made from. It takes both from the BuildInfo embedded in the binary.

This adds a "version" command that does exactly what you'd expect: prints the (module)
version of Tailscale, and the hashmap of the commit the build was made from. It takes both
from the BuildInfo embedded in the binary.
@shayelkin shayelkin mentioned this pull request Sep 4, 2024
@cterence
Copy link
Copy Markdown
Owner

cterence commented Sep 5, 2024

Thanks for your contribution, I'll take a look at it ASAP

Copy link
Copy Markdown
Owner

@cterence cterence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Will be able to merge after resolving the changes I suggested :)

Comment thread cmd/cmd.go Outdated
Comment thread cmd/version.go Outdated
Comment thread cmd/version.go Outdated
shayelkin and others added 2 commits September 12, 2024 16:21
Co-authored-by: Térence <terence.chateigne@posteo.net>
@shayelkin
Copy link
Copy Markdown
Contributor Author

I used to have go fmt (well, (indent-region (point-min) (point-max) nil), but I digress) run on every save.
And your comments is how I found out it stopped working. Sorry for the extra effort from you here.

Comment thread cmd/cmd.go Outdated
@cterence
Copy link
Copy Markdown
Owner

Thank you @shayelkin !

@cterence cterence merged commit ee600ab into cterence:main Sep 13, 2024
@shayelkin shayelkin deleted the add-version-cmd branch September 13, 2024 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants