Remove auto-approval step before merging PR for develop updates#16
Remove auto-approval step before merging PR for develop updates#16The0mikkel merged 3 commits intomainfrom
Conversation
Merge main into develop to update the develop branch to the latest version
There was a problem hiding this comment.
Pull Request Overview
This PR removes the auto-approval step from the develop-update workflow, simplifying the automated PR merge process from main to develop.
- Removes the
gh pr review --approvecommand before merging - Streamlines the auto-merge process to rely on
gh pr merge --autoalone
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gh pr review "${{ steps.create_pr.outputs.URL }}" --approve --body "Auto-approved by CI for merging develop update." | ||
|
|
||
| # Merge PR | ||
| gh pr merge "${{ steps.create_pr.outputs.URL }}" -t "chore(ci): Auto update develop to match main [skip ci]" -b "This was done automatically by the CI pipeline" --merge --auto |
There was a problem hiding this comment.
Removing the auto-approval step may cause issues if the develop branch has branch protection rules requiring PR approvals. The gh pr merge --auto command will enable auto-merge but will wait for all required approvals and status checks before completing the merge. Without the approval step, the PR will remain in a pending state indefinitely if approvals are required, defeating the purpose of auto-merge.
Consider one of the following approaches:
- Ensure the
developbranch does not require approvals for this automated workflow (e.g., by allowing the GitHub Actions bot to bypass approval requirements) - Keep the approval step but use a different token or app with appropriate permissions
- Document that branch protection rules for
developshould not require approvals for this workflow to function correctly
1 participant
No description provided.