Merged
Conversation
added sst1m DigiCam to the default config files (closes #181)
Renaming reco tasks from particletype to type and aitrigger to cherenkov_photons.
The include_nsb_patches flag is now a string of valid option: auto, all, or off. Command line flag for the inclusion of NSB patches has been added accordingly.
also rename config parameter from concat_telescopes to stack_telescope_images
nietootein
approved these changes
May 30, 2024
Member
nietootein
left a comment
nietootein
left a comment
There was a problem hiding this comment.
Go. Superb, @TjarkMiener .
Member
|
CI failing, but that's already fixed on master. Moving forward with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the AItrigger as a regression task.
Requires DL1DH PR#126