Skip to content

Conversation

@jwilkinson87
Copy link
Contributor

This pull request enhances the flexibility and correctness of filter expression formatting in the request router. The main improvements are the addition of support for list values in field filters, improved quoting for string values, and new tests to ensure correct filter formatting, especially for lists and logical expressions.

Filter expression improvements:

  • Updated FieldFilterExpression to support values of any type, including lists, and to properly quote string values and handle nulls. This allows filters like field('a','b','c') to be generated when a list is provided.

Testing enhancements:

  • Added tests to verify that FieldFilterExpression formats lists of values correctly in the filter string.
  • Added tests to ensure that logical expressions like OrExpression work correctly with both list and single field filters, verifying their combined formatting.

Code quality:

  • Added @Suppress("unused") to the OrExpression class to prevent warnings about unused code, improving code clarity.

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@jwilkinson87 jwilkinson87 merged commit 43623e2 into main Oct 16, 2025
2 of 3 checks passed
@jwilkinson87 jwilkinson87 deleted the fix/support-list-values-for-filtering branch October 16, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants