fix: allow use of a list of values for field filtering, and format #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the flexibility and correctness of filter expression formatting in the request router. The main improvements are the addition of support for list values in field filters, improved quoting for string values, and new tests to ensure correct filter formatting, especially for lists and logical expressions.
Filter expression improvements:
FieldFilterExpressionto support values of any type, including lists, and to properly quote string values and handle nulls. This allows filters likefield('a','b','c')to be generated when a list is provided.Testing enhancements:
FieldFilterExpressionformats lists of values correctly in the filter string.OrExpressionwork correctly with both list and single field filters, verifying their combined formatting.Code quality:
@Suppress("unused")to theOrExpressionclass to prevent warnings about unused code, improving code clarity.