task: add ability to get raw payload instead of a parsed map #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
andrew-waters
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new computed property to the
FormSubmissionVersionclass that exposes the payload as a raw JSON string, and adds corresponding tests to verify its correctness. The main goal is to make it easier to access the payload in its serialized form for downstream use or debugging.Feature addition
rawPayloadto theFormSubmissionVersionclass, which serializes thepayloadfield to a JSON string using the shared JacksonObjectMapper. This property handles serialization errors gracefully by returningnullif serialization fails. (src/main/kotlin/com/ctrlhub/core/datacapture/resource/FormSubmissionVersion.kt)Test coverage
FormSubmissionVersionsRouterTestto verify thatrawPayloadis a valid JSON string, starts and ends with curly braces, and contains the expected keys, ensuring the new property works as intended. (src/test/kotlin/com/ctrlhub/core/datacapture/FormSubmissionVersionsRouterTest.kt) [1] [2]