fix: implement resource hydration using Jasminb ResourceConverter #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the resource hydration logic in the
FormSubmissionVersionclass, moving from a custom mapping approach to using Jasminb'sResourceConverterfor JSON:API resource handling. It also removes legacy envelope/data classes, simplifies resource lookup, and updates related tests and models.Refactor and improvement of resource hydration:
ResourceConverter, enabling more robust and extensible JSON:API resource hydration inFormSubmissionVersion. This includes new helper methods for converter configuration and raw resource lookup.JsonApiEnvelopeandJsonApiResourceDataclasses, as hydration now relies on Jasminb's converter and registered types.API and test updates:
hydrateResourceById(id, clazz)as the primary method, and updates tests to use this new method instead of the oldautoHydrateByIdAs. [1] [2]Minor improvements:
@JsonProperty("id")annotation to theidfield in theImagemodel for consistency.