Skip to content

Hydrate relationships from top level includes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgreaves8 merged 5 commits into from
Dec 4, 2024
Merged

Hydrate relationships from top level includes #9

jgreaves8 merged 5 commits into from
Dec 4, 2024

Conversation

@jgreaves8
Copy link
Collaborator

@jgreaves8 jgreaves8 commented Dec 4, 2024 •
edited
Loading

  • Use Hydrator class separately instead of having the logic in BaseService
  • Register models using @RegisterModel decorator, hydrator gets model type for hydration from ModelRegistry
  • Update services, no longer need to declare their model in the construct
  • Remove unused src/services/Services.ts
  • Remove unused src/services/index.ts

@jgreaves8
Fix breaking aliases
479be7b
@jgreaves8
Refactor
594f5e1
@jgreaves8
Refactor
b8ca168 
- Use Hydrator class separately instead of having the logic in BaseService
- Register models using @RegisterModel decorator, hydrator gets model type for hydration from ModelRegistry
- Update services, no longer need to declare their model in the construct
@jgreaves8
Merge main into branch
e0cac2c
@jgreaves8
Remove duplicate export for Equipment
13d307e
@jgreaves8 jgreaves8 requested a review from Karl456 December 4, 2024 13:06
@jgreaves8 jgreaves8 self-assigned this Dec 4, 2024
@jgreaves8 jgreaves8 added the improvement improving features, performance, quality, reliability or security label Dec 4, 2024
@jgreaves8 jgreaves8 merged commit 9bd6685 into main Dec 4, 2024
@jgreaves8 jgreaves8 deleted the hydrate-relationships-from-top-level-includes branch December 4, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Karl456 Karl456 Karl456 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jgreaves8 jgreaves8

Labels

improvement improving features, performance, quality, reliability or security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgreaves8 @Karl456