Upstream 16289 - Do not add optional survey fields with empty strings#242
Merged
Upstream 16289 - Do not add optional survey fields with empty strings#242
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates survey default handling so optional survey questions with an empty-string default don’t automatically inject that key into extra_vars during job launch unless the user explicitly supplies it at runtime.
Changes:
- Skip adding optional, non-password survey defaults when the default is an empty string and the variable is not present in runtime
extra_vars. - Update/extend unit tests to reflect the new behavior and add coverage for explicitly-provided runtime empty strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
awx/main/tests/unit/models/test_survey_models.py |
Updates expectations for optional defaults and adds a new test ensuring runtime-provided empty strings are retained. |
awx/main/models/mixins.py |
Adjusts _update_unified_job_kwargs to omit empty-string defaults for optional survey fields unless explicitly provided at runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When survey fields are optional and not filled out and not backed by a variable in extra_vars, do not inlcude them at all for the job launch.