Upstream 16074 - Validate max_length for scm_branch#243
Merged
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Adds API-side validation to prevent excessively long scm_branch values from being accepted, addressing a workflow launch failure mode where overly long branch strings could leave workflows stuck “running” without starting jobs.
Changes:
- Add
max_length=1024validation toscm_branchin workflow job template/job serializers. - Add
max_length=1024validation toscm_branchin workflow/job launch serializers (including bulk launch). - Centralize the behavior across multiple serializers that previously accepted unbounded branch input.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Notes:
Validates max_length for the scm_branch field in the API.
Our team hit a bug where one of them pasted, by mistake, a very long value at the Source control branch field.
The workflow job templates were in "running" state in the AWX UI, but no job was started. It all led to a debugging session and this PR.