Upstream 16257 - Harden log message output containing user input#244
Merged
Upstream 16257 - Harden log message output containing user input#244
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens webhook notification logging to reduce the risk of log injection by encoding redirect URLs before they are written to logs.
Changes:
- Base64-encodes redirect-related URLs before logging warning/error messages in the webhook notification backend.
- Adds unit tests covering redirect handling (success, blank
Location, max retries) and non-2xx responses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
awx/main/notifications/webhook_backend.py |
Encodes redirect URLs for log-safe warning/error output during redirect handling. |
awx/main/tests/unit/notifications/test_webhook.py |
Adds unit tests for redirect flows and error status handling in send_messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Notes:
base64 encode user inputed url when logging so that newlines or other malicious payloads can't be injected into the log stream