Conversation
cigamit
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a collection of small “best practice” updates across templates, static assets, and backend code, largely focused on accessibility/HTML correctness and minor reliability/maintainability improvements.
Changes:
- Improves HTML/accessibility (adds
lang,alt, and doctype where missing; removes unnecessary attributes). - Fixes/cleans up Python patterns (timezone-aware timestamps, removes invalid
__init__returns, minor logic cleanup). - Tweaks static/error-page styling and assets; minor serializer/view refactors.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| awx/templates/rest_framework/login.html | Removes redundant role="form" attribute on login form. |
| awx/templates/error.html | Adds alt text to logo image for accessibility. |
| awx/static/custom_error.css | Cleans up flex alignment and adds safer font fallbacks. |
| awx/static/custom_504.html | Adds lang="en" and updates image + alt text. |
| awx/static/custom_502.html | Adds lang="en" and updates image + alt text. |
| awx/static/custom_404.html | Adds <!DOCTYPE html> and lang="en". |
| awx/static/api/api.js | Replaces regex-based quote stripping with replaceAll() (compatibility concern noted). |
| awx/main/utils/formatters.py | Uses timezone-aware fromtimestamp(..., tz=...) for log timestamps. |
| awx/main/notifications/grafana_backend.py | Adjusts epoch/time conversions to use timezone-aware datetimes. |
| awx/main/models/unified_jobs.py | Fixes elapsed-time zero comparison for Decimal and removes incorrect websocket started emission. |
| awx/main/models/ha.py | Removes invalid return value from __init__. |
| awx/main/models/base.py | Removes invalid return value from __init__. |
| awx/main/migrations/_inventory_source_vars.py | Removes unused filters handling. |
| awx/api/views/webhooks.py | Renames **kwargs parameter to avoid shadowing local variable use. |
| awx/api/views/init.py | Avoids shadowing args by renaming exception args variable. |
| awx/api/templates/api/stdout.html | Adds lang="en" to HTML. |
| awx/api/serializers.py | Adds defensive check for summary_dict and simplifies host-error dict creation. |
| awx/api/pagination.py | Removes invalid return value from __init__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All good best practice fixes