Upstream 16120 - Gracefully handle hostname change in metrics code#250
Merged
Upstream 16120 - Gracefully handle hostname change in metrics code#250
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts subsystem Prometheus collection to tolerate cases where Valkey/Redis still has metrics keyed by an old hostname, avoiding errors when the current node’s metrics aren’t present yet.
Changes:
- Add a guard in
CustomToPrometheusMetricsCollector.collect()to return early when the current hostname key is missing from the loaded instance payload. - Add debug logging for the “current host metrics missing” case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Upstream Notes:
Previously, we would error out because we assumed that when we got a metrics payload from redis, that there was data in it and it was for the current host.
Now, we do not assume that since we got a metrics payload, that is well formed and for the current hostname because the hostname could have changed and we could have not yet collected metrics for the new host.