Skip to content

Upstream 16366 - avoid delete in loop in inventory import#281

Merged
cigamit merged 2 commits intomainfrom
upstream16366
Mar 30, 2026
Merged

Upstream 16366 - avoid delete in loop in inventory import#281
cigamit merged 2 commits intomainfrom
upstream16366

Conversation

@cigamit
Copy link
Copy Markdown
Contributor

@cigamit cigamit commented Mar 30, 2026

UPSTREAM SUMMARY

For inventory import, avoid running delete in a loop, this is very slow for when the number of hosts is large. Instead, collect all relations that have to be removed with one query and then pass all ids to delete in one go.

This will still create a number of delete queries for large imports, because the batch size is 500, but it still brings the number of queries down significantly.

ASCENDER NOTE
An extra SELECT query was being done unnecessarily for each loop, so apply a quick fix to resolve that

@cigamit cigamit requested a review from TheWitness March 30, 2026 19:50
@cigamit cigamit self-assigned this Mar 30, 2026
Copilot AI review requested due to automatic review settings March 30, 2026 19:50
@cigamit cigamit added the bug Something isn't working label Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves inventory import performance when overwrite=True by batching removal of stale group→group and group→host relationships instead of deleting them one-by-one.

Changes:

  • Batch M2M relationship removals for group children and group hosts during overwrite imports.
  • Add a functional test that verifies stale memberships are removed on overwrite while entities remain present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
awx/main/management/commands/inventory_import.py Batches children.remove(...) / hosts.remove(...) calls to reduce per-relationship delete queries during import overwrite.
awx/main/tests/functional/commands/test_inventory_import.py Adds coverage ensuring overwrite imports remove stale group memberships across successive imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread awx/main/management/commands/inventory_import.py Outdated
Comment thread awx/main/management/commands/inventory_import.py Outdated
@cigamit cigamit merged commit f119849 into main Mar 30, 2026
@cigamit cigamit deleted the upstream16366 branch March 30, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

3 participants