Upstream 16366 - avoid delete in loop in inventory import#281
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves inventory import performance when overwrite=True by batching removal of stale group→group and group→host relationships instead of deleting them one-by-one.
Changes:
- Batch M2M relationship removals for group children and group hosts during overwrite imports.
- Add a functional test that verifies stale memberships are removed on overwrite while entities remain present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
awx/main/management/commands/inventory_import.py |
Batches children.remove(...) / hosts.remove(...) calls to reduce per-relationship delete queries during import overwrite. |
awx/main/tests/functional/commands/test_inventory_import.py |
Adds coverage ensuring overwrite imports remove stale group memberships across successive imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPSTREAM SUMMARY
For inventory import, avoid running delete in a loop, this is very slow for when the number of hosts is large. Instead, collect all relations that have to be removed with one query and then pass all ids to delete in one go.
This will still create a number of delete queries for large imports, because the batch size is 500, but it still brings the number of queries down significantly.
ASCENDER NOTE
An extra SELECT query was being done unnecessarily for each loop, so apply a quick fix to resolve that