Upstream 16344 - Do not ignore errors on activity stream connection#283
Merged
Upstream 16344 - Do not ignore errors on activity stream connection#283
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes silent error suppression when registering activity stream M2M signal handlers so that failures during signal wiring are surfaced instead of being ignored.
Changes:
- Removes
try/except AttributeError: passaround M2M signal registration. - Connects
m2m_changeddirectly for each model M2M field, aligning behavior withdisconnect()(which already doesn’t suppress errors).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Upstream Summary **
Improved error handling to ensure system failures are caught and reported explicitly instead of being silently ignored, enabling faster troubleshooting and issue detection.