Upstream 16346 - Delete unused contains method#284
Merged
Conversation
Its not used, and it has a bug in it that will issue an error
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a buggy __contains__ implementation from SimpleDAG that is not used anywhere in the codebase, preventing a potential runtime error and simplifying the DAG container interface.
Changes:
- Deleted
SimpleDAG.__contains__, which referenced non-existent state (self.node) and could raise an exception. - Relies on existing explicit lookup via
find_ord()/node_obj_to_node_indexfor membership-style checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its not used, and it has a bug in it that will issue an error