Resolve issue where highlighting Job Output text can cause the event popup#298
Merged
Resolve issue where highlighting Job Output text can cause the event popup#298
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an AWX UI Job Output interaction bug where selecting/highlighting text in a clickable job event line unintentionally triggers the host event popup.
Changes:
- Adds a custom click handler that checks for active text selection before invoking the job event click action.
- Updates the
JobEventcomponent to use the new handler on clickable event lines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Its always been a problem that if I wanted to highlight a small section of text in a Job Output event, if that event is clickable (has even data), then highlighting the text will cause the even popup to fire.
This resolves this by checking for this scenario. It will still fire if you highlight the text and then deliberately click the event. It will not fire if only highlighting the text.
ISSUE TYPE
COMPONENT NAME