kt vm: use different qcow images#70
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates kt vm to select Rocky Linux QCOW2 base images by major.minor (e.g., 9.2 vs 9.4) instead of only major version, and adds a CLI option to force re-downloading the base image.
Changes:
- Choose base image names/paths using the kernel’s extracted
major.minorversion. - Add
--override-baseto delete and re-download the shared base QCOW2 before VM creation. - Update Rocky download URL base and documentation/examples to reflect the new image naming.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
kt/ktlib/vm.py |
Adds vm_major_minor_version, uses it for base image selection, and implements base image override re-download logic. |
kt/ktlib/util.py |
Updates Rocky base URL and QCOW2 filename suffix constants used for image downloads. |
kt/KT.md |
Updates the documented base QCOW2 filename example to include major.minor. |
kt/commands/vm/impl.py |
Threads the new override_base flag through the VM command implementation. |
kt/commands/vm/command.py |
Adds the --override-base Click option and documents its behavior in the CLI help text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…sions as well. Rocky 9.4 will use a 9.4 base instead of the latest rocky 9 base. Same for the other kernels. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
This will destroy the vm first if it already exists, but it will also delete the base image from <config.images_source_dir> and download it again, instead of reusing the same base. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
Replaced lts9_4 as kernel parameter instead of lts-9.4. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
71f07f6 to
7523caf
Compare
shreeya-patel98
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ciqinc.atlassian.net/browse/KERNEL-904
Instead of reusing the same base image for all 9.x (latest 9.7 at the moment) or 8.x kernels (latest 8.10 at the moment), we now use the matching qcow images that take into account the minor version as well.
Url used
https://dl.rockylinux.org/vault/rocky/9.2/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2
Added --override-base that will delete the qcow base and download it again. After the vm is deleted of course. Then the vm is setup and instantiated from a fresh base.
While at it, fixed a typo in some command helpers.
Test
Base images
Test for --override-base
Proof the base is downloaded again.