e1000e: Fix return value test

gobenji · Jeff Kirsher · commit d3509f8bc7b0 · 2017-10-10T08:33:24.000-07:00
All the helpers return -E1000_ERR_PHY.

Signed-off-by: Benjamin Poirier &lt;bpoirier@suse.com&gt;
Tested-by: Aaron Brown &lt;aaron.f.brown@intel.com&gt;
Signed-off-by: Jeff Kirsher &lt;jeffrey.t.kirsher@intel.com&gt;
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5099,7 +5099,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
 		break;
 	}
 
-	if ((ret_val == E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&
+	if ((ret_val == -E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&
 	    (er32(CTRL) & E1000_PHY_CTRL_GBE_DISABLE)) {
 		/* See e1000_kmrn_lock_loss_workaround_ich8lan() */
 		e_info("Gigabit has been disabled, downgrading speed\n");

Original file line number	Diff line number	Diff line change
`@@ -5099,7 +5099,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)`
`5099`	`5099`	`break;`
`5100`	`5100`	`}`
`5101`	`5101`
`5102`		`- if ((ret_val == E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&`
	`5102`	`+ if ((ret_val == -E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&`
`5103`	`5103`	`(er32(CTRL) & E1000_PHY_CTRL_GBE_DISABLE)) {`
`5104`	`5104`	`/* See e1000_kmrn_lock_loss_workaround_ich8lan() */`
`5105`	`5105`	`e_info("Gigabit has been disabled, downgrading speed\n");`