Updated component and controller code [B:1767] #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
droberts-ctrlo
commented
May 1, 2025
droberts-ctrlo
commented
- Updated controller to show an error on session expiry rather than generic message
- Updated component to display error message rather than generic one if there is a message to display, otherwise a generic message is given
abeverley
reviewed
Jul 1, 2025
src/frontend/components/form-group/select-widget/lib/component.js
Outdated
Show resolved
Hide resolved
src/frontend/components/form-group/select-widget/lib/component.js
Outdated
Show resolved
Hide resolved
Data was being correctly returned as JSON rather than string, so marshalling of data is not required. This functionality has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.