Skip to content

fix: resource variableSync failure#56

Merged
zacharyblasczyk merged 1 commit intomainfrom
fix-syncVariables-status
Feb 25, 2026
Merged

fix: resource variableSync failure#56
zacharyblasczyk merged 1 commit intomainfrom
fix-syncVariables-status

Conversation

@zacharyblasczyk
Copy link
Member

@zacharyblasczyk zacharyblasczyk commented Feb 25, 2026

Match the openapi spec.

Example error:

✗ Resource/example-amazon: update failed: All attempts fail:
#1: failed to update resource variables: {"id":"d8c530a2-9da8-40e6-91bc-ebc5323befe0","message":"Resource variables update requested"}

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of resource variable update responses to ensure proper success and error recognition.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7d55a78 and a4cc364.

📒 Files selected for processing (1)
  • internal/api/providers/resource.go

📝 Walkthrough

Walkthrough

Modified the HTTP status code accepted for successful resource variable updates from 204 to 202 in the syncVariables function. The change treats 202 as a success response while preserving existing error handling logic for other status codes and 404 retries.

Changes

Cohort / File(s) Summary
HTTP Status Code Update
internal/api/providers/resource.go
Changed accepted success status code from 204 to 202 for resource variable synchronization; non-404 non-202 responses now treated as unrecoverable errors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops with glee, hooray! 🐰
Status codes have changed today,
Two-oh-two now marks success,
No more two-oh-four's duress,
Acceptance flows in a brand new way!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: fixing a resource variable synchronization failure by updating the accepted HTTP status code from 204 to 202, which aligns with the OpenAPI spec and resolves the synchronization error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-syncVariables-status

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zacharyblasczyk zacharyblasczyk merged commit 99d1c34 into main Feb 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants