Typo: minimumSockTimeMinutes should be minimumSoakTimeMinutes in API contract

[zacharyblasczyk]

Summary

The public API field minimumSockTimeMinutes is a typo — it should be minimumSoakTimeMinutes (missing the "a" in "Soak"). The database column is correctly named minimumSoakTimeMinutes, and explicit mapping code translates between the two names at the API boundary. This typo is baked into the OpenAPI spec, generated types, Go SDK, and documentation.

Why this matters

• Confusing API surface — "sock time" is not a meaningful concept. Integrators have to guess or look at docs to realize this means "soak time" (the practice of letting a release sit in an environment before progressing).
• Unnecessary translation layer — The API routes contain explicit mapping code that exists solely to bridge the typo in the public contract with the correct name in the database. This is dead weight that makes the code harder to follow.
• SDK propagation — Generated SDKs (Go, TypeScript) carry the typo into downstream consumers, compounding the confusion.
• Documentation inconsistency — Some docs reference the typo (minimumSockTimeMinutes) and others the correct name (minimumSoakTimeMinutes), making it unclear which is canonical.

Where it happens

The typo originates in the jsonnet schema definitions for the API and workspace engine OpenAPI specs. From there it propagates to:

• Generated OpenAPI JSON specs
• Generated TypeScript types (API app, web app, workspace-engine-sdk)
• Generated Go types (workspace-engine)
• tRPC and REST API route code (which maps between the typo and the correct DB column name)
• Policy documentation (overview and environment-progression pages)

The database schema and internal services all use the correct spelling minimumSoakTimeMinutes.

Suggested fix

This is a breaking change to the public API contract, so it should be handled carefully:

1. Rename minimumSockTimeMinutes → minimumSoakTimeMinutes in the jsonnet schema definitions.
2. Regenerate OpenAPI specs and all generated types.
3. Remove the mapping layer in the tRPC and REST API routes — the field name will match the DB column directly.
4. Update documentation references.
5. Consider accepting both field names temporarily for backward compatibility, or bundle this into a versioned API release.

[adityachoudhari26]

@claude fix this issue

[claude]

Claude finished @adityachoudhari26's task in 2m 29s —— View job • claude/issue-888-20260330-1727 • Create PR ➔

---

Fixing typo: minimumSockTimeMinutes → minimumSoakTimeMinutes

• Gather context: explore codebase for all occurrences (12 files affected)
• Fix jsonnet schema definitions (apps/api/openapi/schemas/policies.jsonnet, apps/workspace-engine/oapi/spec/schemas/policy.jsonnet)
• Fix generated OpenAPI specs (apps/api/openapi/openapi.json, apps/workspace-engine/oapi/openapi.json)
• Fix TypeScript types (apps/api/src/types/openapi.ts, apps/web/app/api/openapi.ts, packages/workspace-engine-sdk/src/schema.ts)
• Fix generated Go types (apps/workspace-engine/pkg/oapi/oapi.gen.go)
• Fix tRPC/REST API route mapping code — removed the bridging layer, field names now match DB directly (apps/api/src/routes/v1/workspaces/policies.ts, packages/trpc/src/routes/policies.ts)
• Update documentation references (docs/policies/overview.mdx, docs/policies/environment-progression.mdx)
• Commit and push changes

All 12 occurrences of minimumSockTimeMinutes have been renamed to minimumSoakTimeMinutes. The unnecessary mapping layer (which existed solely to bridge the typo with the correct DB column name) has been cleaned up.