Skip to content

fix: aggregate page uses correct param#1004

Merged
adityachoudhari26 merged 1 commit intomainfrom
resource-aggrate-correct-redirect
Apr 16, 2026
Merged

fix: aggregate page uses correct param#1004
adityachoudhari26 merged 1 commit intomainfrom
resource-aggrate-correct-redirect

Conversation

@adityachoudhari26
Copy link
Copy Markdown
Member

@adityachoudhari26 adityachoudhari26 commented Apr 16, 2026

fixes #994

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the query parameter naming in resource-aggregate navigation URLs for improved consistency and compatibility with the application's routing system.

Copilot AI review requested due to automatic review settings April 16, 2026 21:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d1ba738-625a-46a1-b3d4-6b14322b9c67

📥 Commits

Reviewing files that changed from the base of the PR and between 945c59c and 779ae90.

📒 Files selected for processing (1)
  • apps/web/app/routes/ws/resource-aggregates/page.$aggregateId.tsx

📝 Walkthrough

Walkthrough

The navigation query parameter for filtering resources via resource-aggregate groups has been renamed from cel to query. This single-line change updates the URL routing structure to use the correct parameter name.

Changes

Cohort / File(s) Summary
Query Parameter Fix
apps/web/app/routes/ws/resource-aggregates/page.$aggregateId.tsx
Updated resource filter navigation to use query parameter instead of cel when routing to resources page from aggregate group selection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a skip, a parameter's flip,
From "cel" to "query," no longer a slip,
Resources now filter with one little change,
Aggregates dancing—no longer so strange! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the aggregate page to use the correct query parameter name.
Linked Issues check ✅ Passed The change directly addresses issue #994 by fixing the query parameter name from 'cel' to 'query' to restore filter functionality.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to fixing the query parameter name in the resource-aggregate navigation, directly related to issue #994.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch resource-aggrate-correct-redirect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the resource aggregates detail page navigation so that clicking an aggregate group correctly applies its CEL filter on the Resources page (issue #994).

Changes:

  • Update the Resources page URL query parameter from cel to the expected query parameter when navigating from an aggregate group row.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adityachoudhari26 adityachoudhari26 merged commit 7204759 into main Apr 16, 2026
12 checks passed
@adityachoudhari26 adityachoudhari26 deleted the resource-aggrate-correct-redirect branch April 16, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on an aggerate nolonger apply its filter to the resources

2 participants