feat: dry run commit check links back to individual plan result

[adityachoudhari26]

fixes #1031

[coderabbitai]

Warning

Rate limit exceeded

@adityachoudhari26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 17 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 17 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 98e44954-233d-4236-9f18-1afea640db6c

📥 Commits

Reviewing files that changed from the base of the PR and between a7fdee7 and 871f707.

📒 Files selected for processing (2)

• apps/workspace-engine/svc/controllers/deploymentplanresult/github_check.go
• apps/workspace-engine/svc/controllers/deploymentplanresult/github_check_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch commit-check-plan-details-link

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Updates the GitHub check run “Details” URL (and the summary link) so it deep-links into the Ctrlplane UI for a specific deployment plan result, addressing issue #1031.

Changes:

• Update plan “Details” URL construction to use resultId (instead of target) so the UI can open the diff dialog for a specific result.
• Thread resultID through check output building and check run upsert.
• Update unit test call site for the buildCheckOutput signature change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
apps/workspace-engine/svc/controllers/deploymentplanresult/github_check.go	Builds check run details/summary URLs using resultId and threads resultID through output + upsert.
apps/workspace-engine/svc/controllers/deploymentplanresult/github_check_test.go	Updates buildCheckOutput invocation to include a resultID.

Comments suppressed due to low confidence (1)

apps/workspace-engine/svc/controllers/deploymentplanresult/github_check_test.go:281

• This test was updated to pass a resultID, but it doesn't assert that the generated summary URL actually contains the resultId query param (the new behavior in this PR). Use a deterministic UUID in the test and add an assertion that *out.Summary includes resultId=<uuid> so regressions are caught.

	out := buildCheckOutput(tc, uuid.New(), results, agg)

	require.NotNil(t, out)
	require.NotNil(t, out.Title)
	require.NotNil(t, out.Summary)
	require.NotNil(t, out.Text)

	assert.Contains(t, *out.Summary, "v1.2.3")
	assert.Contains(t, *out.Summary, "/acme/deployments/")
	assert.Contains(t, *out.Summary, tc.PlanID.String())

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

targetDetailsURL now builds a URL keyed by resultID (and uses resultId query param), so the helper name no longer matches what it returns. Consider renaming the function (and call sites) to something like resultDetailsURL/planResultDetailsURL to avoid future confusion.

[Copilot]

The summary link text still says "View full plan" but the URL now includes resultId=... and (per the comment above) will open the diff dialog for a specific result on page load. Update the link label to match the new behavior (e.g., "View result" / "View diff"), so users aren't surprised by the deep-link.

Suggested change

	fmt.Fprintf(&summary, "[View full plan →](%s)\n", targetDetailsURL(tc, resultID))
	fmt.Fprintf(&summary, "[View diff →](%s)\n", targetDetailsURL(tc, resultID))