fix: Update all jobs in environment for release

[adityachoudhari26]

Summary by CodeRabbit

• New Features

  • Introduced an interactive dropdown in job tables, enabling users to access options for overriding job statuses.
  • Integrated the new dropdown into the job release interface for enhanced control.

• Refactor

  • Updated the job management flow to support batch updates, allowing multiple job statuses to be modified simultaneously.

[coderabbitai]

Walkthrough

This pull request introduces a new React functional component, EnvironmentRowDropdown, which manages a dropdown menu integrated into the release table UI. The component, which accepts an array of job IDs and children elements, renders an OverrideJobStatusDialog for updating job statuses. Additionally, the JobDropdownMenu has been updated to pass multiple job IDs using a new mutation hook (api.job.updateMany.useMutation()). On the API side, a new updateMany method is added to the job router to support batch updates with proper authorization checks.

Changes

File(s)	Change Summary
apps/webservice/.../jobs/release-table/EnvironmentRowDropdown.tsx apps/webservice/.../jobs/release-table/ResourceReleaseTable.tsx	Added the EnvironmentRowDropdown component and integrated it into the release table to handle job-related dropdown actions.
apps/webservice/.../_components/job/JobDropdownMenu.tsx	Updated OverrideJobStatusDialog to accept an array of job IDs and modified the mutation logic to use api.job.updateMany.useMutation() for batch updates.
packages/api/src/router/job.ts	Introduced the new updateMany method which processes batch job updates with authorization checks and concurrent execution.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant E as EnvRowDropdown
  participant O as OverrideDialog
  participant J as JobDropdownMenu
  participant API as Job API
  participant DB as Database

  U->>E: Click trigger (children)
  E->>U: Display dropdown menu
  U->>E: Select "Override Job Status"
  E->>O: Open OverrideJobStatusDialog with jobIds
  O->>J: Submit status update
  J->>API: Call updateMany(jobIds, data)
  API->>DB: Execute batch update with auth check
  DB-->>API: Return update result
  API-->>J: Return update result
  J->>O: Close dialog

Loading

Possibly related PRs

• fix: Deployment resource drawer #237: Modified OverrideJobStatusDialog to accept arrays of job IDs, directly relating to the updated batch update logic.
• fix: Optimize release list query and use lazy loading for release cells #269: Integrated EnvironmentRowDropdown into the ResourceReleaseTable, sharing similar UI job management functionality.
• fix: Target redeploy #210: Introduced the EnvironmentRowDropdown alongside updates in OverrideJobStatusDialog for batch job updates, ensuring consistency across components.

Suggested reviewers

• jsbroks

Poem

I’m a rabbit with a coder’s beat,
Hopping through dropdowns, light on my feet.
Multiple jobs now update in a flash,
With dialogs and APIs working in a dash.
I nibble on clean code with a joyful heart,
Celebrating changes—a fresh new start!
🐇💻 Hop on and code smart!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84ca58a and 2350cc3.

📒 Files selected for processing (4)

• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/EnvironmentRowDropdown.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx (3 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/_components/job/JobDropdownMenu.tsx (5 hunks)
• packages/api/src/router/job.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• packages/api/src/router/job.ts
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/EnvironmentRowDropdown.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/_components/job/JobDropdownMenu.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Lint
• GitHub Check: Typecheck
• GitHub Check: build (linux/amd64)

🔇 Additional comments (11)

apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/ResourceReleaseTable.tsx (3)

43-43: New component import looks good

The import of EnvironmentRowDropdown is clean and follows the project's import style.

---

79-79: Good use of array mapping

Creating an array of all job IDs from the triggers is an efficient approach for batch operations.

---

175-181: Well-implemented dropdown integration

The EnvironmentRowDropdown is properly integrated in the UI, positioned alongside the environment approvals. The component receives all job IDs and wraps a button with the appropriate styling.

apps/webservice/src/app/[workspaceSlug]/(appv2)/(deploy)/(raw)/systems/[systemSlug]/(raw)/deployments/[deploymentSlug]/(raw)/releases/[releaseId]/jobs/release-table/EnvironmentRowDropdown.tsx (1)

1-36: Well-structured component implementation

This new component follows React best practices:

• Clean prop interface with appropriate types
• Proper state management with useState
• Good component composition using children prop
• Follows the project's UI component patterns

The dropdown is correctly configured to handle the open state and to close when actions are completed.

packages/api/src/router/job.ts (1)

785-802: Robust implementation of batch update API

The updateMany method is well implemented with:

• Proper input validation using zod
• Thorough authorization checks for each job ID
• Efficient concurrent updates using Promise.all
• Consistent error handling approach

This implementation allows for batch operations while maintaining proper authorization requirements, which is a secure approach.

apps/webservice/src/app/[workspaceSlug]/(appv2)/_components/job/JobDropdownMenu.tsx (6)

72-76: Good prop interface refactoring

The component props have been properly refactored to accept an array of job IDs instead of a single job object, making it more flexible for batch operations.

---

78-78: Appropriate mutation hook update

Updated to use the new updateMany mutation hook which aligns with the API changes.

---

86-94: Well-implemented form submission logic

The onSubmit function has been properly updated to:

• Use the new updateMany mutation
• Pass an array of job IDs
• Invalidate relevant cache entries
• Handle the component state properly

This ensures data consistency across the UI after batch updates.

---

142-146: Error handling properly updated

Error handling has been correctly updated to reference the new mutation variable.

---

156-156: Loading state correctly managed

The disabled state of the submit button now correctly references the new mutation's pending state.

---

362-365: Proper integration with existing dropdown menu

The component is now called with the correct props, passing an array with a single job ID to maintain backward compatibility while enabling the new batch update functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.