fix: Typecheck on var change

[adityachoudhari26]

Summary by CodeRabbit

• Refactor
  • Streamlined the backend process for retrieving and processing release information to reduce redundancy and improve maintainability.
• Chores
  • Made minor dependency updates to support the optimized query handling.

[coderabbitai]

Walkthrough

The changes introduce a new asynchronous function getResourceReleases that centralizes the database query logic for resource releases by joining the resourceRelease and resource tables while filtering out deleted resources. The refactoring updates the handlers for deployment, system, and resource variable changes to use this new function, eliminating repetitive queries. Additionally, a required import for and from @ctrlplane/db has been added to support the new query logic.

Changes

File(s)	Change Summary
apps/event-worker/src/releases/variable-change/index.ts	- Added getResourceReleases async function for encapsulating the database query logic. - Refactored handleDeploymentVariableChange, handleSystemVariableChange, and handleResourceVariableChange to use the new function. - Added import of and from @ctrlplane/db.

Sequence Diagram(s)

sequenceDiagram
    participant Handler as VariableChangeHandler
    participant GR as getResourceReleases
    participant DB as Database

    Handler->>GR: Call getResourceReleases(query conditions)
    GR->>DB: Execute joined query on resourceRelease and resource tables
    DB-->>GR: Return combined query results
    GR-->>Handler: Return mapped resource data

Loading

Poem

Oh, happy hops in refactored code,
With no more duplicate loads to decode.
A single function now leads the way,
Along the bunny trail of query display.
CodeRabbit waves, in a joyful mode—
A cleaner path for our data to explode!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b27aadd and fece0e6.

📒 Files selected for processing (1)

• apps/event-worker/src/releases/variable-change/index.ts (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/event-worker/src/releases/variable-change/index.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: build (linux/amd64)
• GitHub Check: Lint

🔇 Additional comments (5)

apps/event-worker/src/releases/variable-change/index.ts (5)

1-1: Import additions for SQL and and operator look good.

These imports support the refactored query logic, allowing for proper typing of the where parameter and composition of SQL conditions.

Also applies to: 6-6

---

19-30: Well-designed centralization of database query logic.

The new getResourceReleases function effectively encapsulates the repetitive database query pattern that was previously duplicated across multiple handlers. The function:

• Takes a flexible SQL where condition parameter
• Properly joins the relevant tables
• Filters out deleted resources with isNull(schema.resource.deletedAt)
• Maps the results to a consistent structure

This refactoring improves maintainability and reduces duplication.

---

41-43: Good refactoring of deployment variable change handler.

The function now uses the centralized getResourceReleases function while maintaining the same behavior and error handling. The SQL condition correctly filters by deployment ID.

---

60-62: Good refactoring of system variable change handler.

The function now uses the centralized getResourceReleases function while maintaining the same behavior and error handling. The SQL condition correctly filters by deployment ID from the joined system.

---

65-68: Good simplification of resource variable change handler.

The function has been simplified to an arrow function that directly calls getResourceReleases with the appropriate SQL condition. This makes the code more concise and consistent with the other handlers.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.