Skip to content

fix: Typecheck on var change #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix: Typecheck on var change #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions apps/event-worker/src/releases/variable-change/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type { SQL } from "@ctrlplane/db";
import type { ReleaseRepository } from "@ctrlplane/rule-engine";
import type { ReleaseVariableChangeEvent } from "@ctrlplane/validators/events";
import { Worker } from "bullmq";

import { eq, isNull, takeFirstOrNull } from "@ctrlplane/db";
import { and, eq, isNull, takeFirstOrNull } from "@ctrlplane/db";
import { db } from "@ctrlplane/db/client";
import * as schema from "@ctrlplane/db/schema";
import {
Expand All @@ -15,6 +16,19 @@ import {
import { redis } from "../../redis.js";
import { createAndEvaluateRelease } from "../create-release.js";

const getResourceReleases = async (where: SQL) =>
db
.select()
.from(schema.resourceRelease)
.innerJoin(
schema.resource,
eq(schema.resourceRelease.resourceId, schema.resource.id),
)
.where(and(where, isNull(schema.resource.deletedAt)))
.then((rows) =>
rows.map((r) => ({ ...r.resource_release, resource: r.resource })),
);

const handleDeploymentVariableChange = async (deploymentVariableId: string) => {
const variable = await db
.select()
Expand All @@ -24,10 +38,9 @@ const handleDeploymentVariableChange = async (deploymentVariableId: string) => {

if (variable == null) throw new Error("Deployment variable not found");

return db.query.resourceRelease.findMany({
where: eq(schema.resourceRelease.deploymentId, variable.deploymentId),
with: { resource: { where: isNull(schema.resource.deletedAt) } },
});
return getResourceReleases(
eq(schema.resourceRelease.deploymentId, variable.deploymentId),
);
};

const handleSystemVariableChange = async (systemVariableSetId: string) => {
Expand All @@ -44,18 +57,15 @@ const handleSystemVariableChange = async (systemVariableSetId: string) => {

if (deployment == null) throw new Error("System variable set not found");

return db.query.resourceRelease.findMany({
where: eq(schema.resourceRelease.deploymentId, deployment.id),
with: { resource: { where: isNull(schema.resource.deletedAt) } },
});
return getResourceReleases(
eq(schema.resourceRelease.deploymentId, deployment.id),
);
};

const handleResourceVariableChange = async (resourceVariableId: string) => {
return db.query.resourceRelease.findMany({
where: eq(schema.resourceRelease.resourceId, resourceVariableId),
with: { resource: { where: isNull(schema.resource.deletedAt) } },
});
};
const handleResourceVariableChange = async (resourceVariableId: string) =>
getResourceReleases(
eq(schema.resourceRelease.resourceId, resourceVariableId),
);

export const createReleaseVariableChangeWorker = () =>
new Worker<ReleaseVariableChangeEvent>(
Expand Down
Loading