Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reformats/regenerates the workspace-engine-sdk OpenAPI TypeScript schema output to match the project’s current formatting/generated layout, keeping the SDK’s exported typings aligned with the workspace-engine OpenAPI artifact.
Changes:
- Re-formatted the generated
src/schema.tsoutput (indentation/layout) without intended behavioral changes. - Regenerated the
paths,components.schemas, andoperationstypings to the latest emitted structure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * Compute resource aggregate | ||
| * @description Filters resources by a CEL expression and groups them by specified properties, returning counts per group. | ||
| */ | ||
| post: operations["computeAggergate"]; | ||
| delete?: never; |
There was a problem hiding this comment.
Nit: computeAggergate appears to be a misspelling of “computeAggregate”. Since this file is generated from the OpenAPI spec, the fix likely needs to happen at the operationId level (then regenerate). If changing the operationId would be a breaking change for existing SDK consumers, consider adding a deprecated alias in a hand-written wrapper layer while keeping the generated types in sync with the spec.
| /** | ||
| * Format: int32 | ||
| * @description Minimum time to wait after the depends on environment is in a success state before the current environment can be deployed | ||
| * @default 0 | ||
| */ | ||
| minimumSockTimeMinutes: number; | ||
| /** |
There was a problem hiding this comment.
Nit: minimumSockTimeMinutes looks like it was intended to be “minimumSoakTimeMinutes” (the description refers to a soak-time delay). Because this is generated, the proper place to fix it is the OpenAPI schema source and then regenerate the SDK; if this field is already in use, consider a deprecation/compatibility plan before renaming.
No description provided.