Disable devTools by default if NODE_ENV === production#14
Disable devTools by default if NODE_ENV === production#14ctrlplusb merged 2 commits intoctrlplusb:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 5 5
Lines 142 142
Branches 25 25
=======================================
Hits 141 141
Misses 1 1
Continue to review full report at Codecov.
|
|
Ah - just read https://hackernoon.com/whats-new-with-server-side-rendering-in-react-16-9b0d78585d67#d14d which I didn't know about... |
|
Yeah, let's avoid any possible performance issues as it is very possible the process.env would be hit per request in an SSR environment. Fixing the property name definitely helps though!! 😊 We could consider more docs around this to educate adopters and allow them to choose a performance strategy that suits them. 👍 |
|
Hi - the README now notes incorrectly that |
|
Woops. I'll fix. Ta |
and fix the typo in the README