Skip to content

Disable devTools by default if NODE_ENV === production#14

Merged
ctrlplusb merged 2 commits intoctrlplusb:masterfrom
christianchown:devtools-production
Nov 8, 2018
Merged

Disable devTools by default if NODE_ENV === production#14
ctrlplusb merged 2 commits intoctrlplusb:masterfrom
christianchown:devtools-production

Conversation

@christianchown
Copy link
Contributor

and fix the typo in the README

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files           5        5           
  Lines         142      142           
  Branches       25       25           
=======================================
  Hits          141      141           
  Misses          1        1
Impacted Files Coverage Δ
src/easy-peasy.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d615197...004228b. Read the comment docs.

@christianchown
Copy link
Contributor Author

Ah - just read https://hackernoon.com/whats-new-with-server-side-rendering-in-react-16-9b0d78585d67#d14d which I didn't know about...

@ctrlplusb
Copy link
Owner

Yeah, let's avoid any possible performance issues as it is very possible the process.env would be hit per request in an SSR environment. Fixing the property name definitely helps though!! 😊

We could consider more docs around this to educate adopters and allow them to choose a performance strategy that suits them. 👍

@ctrlplusb ctrlplusb merged commit 3b01cec into ctrlplusb:master Nov 8, 2018
@christianchown christianchown deleted the devtools-production branch November 8, 2018 11:46
@christianchown
Copy link
Contributor Author

Hi - the README now notes incorrectly that devTools default is true if NODE_ENV !== 'production' rather than true

@ctrlplusb
Copy link
Owner

Woops. I'll fix. Ta

ctrlplusb pushed a commit that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants