use getcurpos/setpos instead of winsaveview/winrestview

[mattn]

Close #256

@jonathanewerner @tacahiroy Could you please try this?

[tacahiroy]

I don't see any differences between them. I mean both implementations work well.
So if @jonathanewerner confirms this PR improves performance it's ok.

[jonathanglasmeyer]

No, the felt performance is identical.
I switched back to https://github.com/kien/ctrlp.vim for the time being because perf is good there. (But other bugs are present :/)

You can't see it really well because of the framerate, but here is a visual comparison:

kien/ctrlp.vim

Its very fluid, even more in the up motion (fps is like twice higher for up motion compared to the down motion 🤔)

this repo

It janky & the cursor jumps to the end of line shortly for each line which probably is the main culprit..

[mattn]

@jonathanewerner have you seen #186 ?

[mattn]

okay, I'll merge this. and if you still have problem, please file new issue.

[Roguelazer]

I think this broke something; ctrlp now only works on the super-modern Vim I have installed from Homebrew; in the slightly older MacVim, I get the following error:

E121: Undefined variable: pos
E116: Invalid arguments for function setpos

Working version:

% /usr/local/bin/vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 14 2016 16:34:13)
MacOS X (unix) version
Included patches: 1-1910
Compiled by Homebrew

Non-working version:

% vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 21 2014 14:54:22)
MacOS X (unix) version
Included patches: 1-258
Compiled by Bjorn Winckler <bjorn.winckler@gmail.com>

[mattn]

Could you please try last commit?

[jonathanglasmeyer]

What does #186 have to do with this?

[mattn]

kien/ctrlp move up cursor if set let g:ctrlp_lazy_update = 1. So I fixed it.

[Roguelazer]

@mattn it works now, thanks!

[mattn]

👏