Skip to content

Feature/use sqlmodel#12

Merged
saipavan10-git merged 4 commits into
developfrom
feature/use_sqlmodel
Dec 5, 2023
Merged

Feature/use sqlmodel#12
saipavan10-git merged 4 commits into
developfrom
feature/use_sqlmodel

Conversation

@michael-bentz
Copy link
Copy Markdown
Contributor

What does this change do?

This change refactors orm.py to use SQLModel instead of SQLAlchemy.

Why was this change made?

This change was made to:

  • Minimize code duplication. A single type annotation does a lot of work. No need to duplicate models in SQLAlchemy and Pydantic.
  • Simplify the developer experience by working directly with objects.

Verification

  1. Verify that all automated tests pass.

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I have added docstrings with details on keyword arguments to new functions following the convention detailed in this gist
  • I have added type hinting to new function parameters.
  • I have added tests to new functions, following the rules of F.I.R.S.T..
  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

Copy link
Copy Markdown
Contributor

@saipavan10-git saipavan10-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, and ran the test cases. Everything looks fine.

@saipavan10-git saipavan10-git merged commit 1e8fdfe into develop Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants