Skip to content

Fix update_model function#13

Merged
saipavan10-git merged 3 commits into
developfrom
fix/update_model
Dec 11, 2023
Merged

Fix update_model function#13
saipavan10-git merged 3 commits into
developfrom
fix/update_model

Conversation

@michael-bentz
Copy link
Copy Markdown
Contributor

What does this change do?

Fixes the update_model function.

Why was this change made?

Passing kwargs as the last parameter was causing update_model to not behave as expected when not explicitly setting pk_field.

Verification

  1. Verify that all automated tests pass
  2. Debug and step through test_orm to make sure the logic is sound
  • Verify the thing does this: ...
  • Verify the thing does not do that: ...

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I have added docstrings with details on keyword arguments to new functions following the convention detailed in this gist
  • I have added type hinting to new function parameters.
  • I have added tests to new functions, following the rules of F.I.R.S.T..
  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

@michael-bentz michael-bentz changed the base branch from master to develop December 11, 2023 14:57
Copy link
Copy Markdown
Contributor

@saipavan10-git saipavan10-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes and ran the test debugger on test_orm.py. The code works as expected.

@saipavan10-git saipavan10-git merged commit 5c3a4ba into develop Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants