Skip to content

Add eager loading support for query_model and deprecate update_model#14

Merged
saipavan10-git merged 1 commit into
developfrom
feature/add_support_for_eager_loading
Dec 13, 2023
Merged

Add eager loading support for query_model and deprecate update_model#14
saipavan10-git merged 1 commit into
developfrom
feature/add_support_for_eager_loading

Conversation

@michael-bentz
Copy link
Copy Markdown
Contributor

What does this change do? Please be clear and concise.

Add eager loading support for query_model and deprecate update_model

Why was this change made?

Eager loading support simplifies making changes and interacting with the database.

Verification

  1. Verify that all automated workflows pass.
  2. Verify that the logic of test_update_model is sound.

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I have added docstrings with details on keyword arguments to new functions following the convention detailed in this gist
  • I have added type hinting to new function parameters.
  • I have added tests to new functions, following the rules of F.I.R.S.T..
  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

@michael-bentz michael-bentz force-pushed the feature/add_support_for_eager_loading branch from bcbc78e to 1d3d245 Compare December 12, 2023 16:53
Copy link
Copy Markdown
Contributor

@saipavan10-git saipavan10-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code. The test_update_model unit test works as expected. The image table field does get updated. The context management of Session also looks good.

@saipavan10-git saipavan10-git merged commit 8cd9f93 into develop Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants