Skip to content

Add tests for ScriptHelper#18

Merged
sinarest1608 merged 2 commits into
developfrom
feature/add_script_helper
Feb 23, 2024
Merged

Add tests for ScriptHelper#18
sinarest1608 merged 2 commits into
developfrom
feature/add_script_helper

Conversation

@michael-bentz
Copy link
Copy Markdown
Contributor

What does this change do?

Adds tests for ScriptHelper

Why was this change made?

This should have been a part of #16, but was left out.

Verification

  1. Verify that all tests pass

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I have added docstrings with details on keyword arguments to new functions following the convention detailed in this gist
  • I have added type hinting to new function parameters.
  • I have added tests to new functions, following the rules of F.I.R.S.T..
  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

Copy link
Copy Markdown
Contributor

@sinarest1608 sinarest1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed

@sinarest1608 sinarest1608 merged commit a5e1378 into develop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants